Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic device widget, and StateDeviceWidget #120

Merged
merged 16 commits into from
Mar 3, 2022
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Mar 2, 2022

a start on creating more generic widgets that work for given device types.

This establishes new base class DeviceWidget that accepts the name of a device and is expected to make widget that controls the device. In most cases, it will be created with the classmethod DeviceWidget.for_device('deviceLabel') which creates the appropriate subclass. Here, StateDevice is implemented... but for_device will raise a NotImplementedError for all other device types (to be implemented later).

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #120 (ced46b0) into main (23994fe) will increase coverage by 0.70%.
The diff coverage is 98.14%.

❗ Current head ced46b0 differs from pull request most recent head 0b479a7. Consider uploading reports for the commit 0b479a7 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   74.92%   75.63%   +0.70%     
==========================================
  Files          19       20       +1     
  Lines        1715     1769      +54     
==========================================
+ Hits         1285     1338      +53     
- Misses        430      431       +1     
Impacted Files Coverage Δ
micromanager_gui/_gui_objects/_device_widget.py 98.14% <98.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23994fe...0b479a7. Read the comment docs.

@tlambert03 tlambert03 merged commit 7026f32 into main Mar 3, 2022
@tlambert03 tlambert03 deleted the device-widget branch March 3, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant