-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a widget to create pixel size configurations #141
Conversation
Codecov Report
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 85.84% 86.29% +0.44%
==========================================
Files 31 32 +1
Lines 3010 3218 +208
==========================================
+ Hits 2584 2777 +193
- Misses 426 441 +15
Continue to review full report at Codecov.
|
What happens if you click |
@ianhi it's just my opinion but I think we should make the user decide how to set the configuration...in some cases they can add some optical components in the path that will be used only with a specific objective, etc... |
is it possible to directly modify image pixel size? (doesn't look like it is yet). I don't think the user should be "forced" to use the camera pixel/mag math... If they know their image pixel size (which is the default interface in micromanager right?) they should be allowed to enter it |
@tlambert03 I think everything is working as it should now... |
closing since it has been moved to https://github.com/pymmcore-plus/pymmcore-widgets. |
did this feature specifically get implemented? If not, we shouldn't close the issue (but we can transfer it) |
@tlambert03 yes sorry, I've added it to pymmcore-widgets. |
Can you link the pr here so we can see it? |
😂 ... that links to this PR. looking through your history, I'm guessing it was pymmcore-plus/pymmcore-widgets#6 If I recall, there were definitely some UI and organization-related questions remaining to be answered in this PR. Let's not merge un-discussed, un-reviewed things into the new repo. 🙏 |
😂 sorry I didn't get that. yes that's the one. do you want me to reopen it in pymmcore-widgets? I can remove the set_pixel_size_widget.py and the test if you want. same for shutter_widget.py. |
No, just create issues reminding us as a group to evaluate them |
This might be a temporary solution to set the pixel size. As @tlambert03 mentioned in #136 (I'm adding a
Micro-Manager
menu...), this widget could be placed in the menu and the user can define pixel size configs from there.What do you think?
Untitled.mov