Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a widget to create pixel size configurations #141

Closed
wants to merge 26 commits into from

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Mar 7, 2022

This might be a temporary solution to set the pixel size. As @tlambert03 mentioned in #136 (I'm adding a Micro-Manager menu...), this widget could be placed in the menu and the user can define pixel size configs from there.

What do you think?

Untitled.mov

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #141 (2db90e6) into main (de45a8c) will increase coverage by 0.44%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   85.84%   86.29%   +0.44%     
==========================================
  Files          31       32       +1     
  Lines        3010     3218     +208     
==========================================
+ Hits         2584     2777     +193     
- Misses        426      441      +15     
Impacted Files Coverage Δ
micromanager_gui/main_window.py 75.87% <45.45%> (-1.55%) ⬇️
micromanager_gui/_core_widgets/_set_pixel_size.py 95.45% <95.45%> (ø)
micromanager_gui/_core_widgets/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de45a8c...2db90e6. Read the comment docs.

@ianhi
Copy link
Contributor

ianhi commented Mar 8, 2022

What happens if you click new row? Am I right that in most cases there will only be one combobox of objectives? If that's the case then I think we should just display all the rows at once and you click around to choose which ones to edit.

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Mar 8, 2022

What happens if you click new row? Am I right that in most cases there will only be one combobox of objectives? If that's the case then I think we should just display all the rows at once and you click around to choose which ones to edit.

@ianhi it's just my opinion but I think we should make the user decide how to set the configuration...in some cases they can add some optical components in the path that will be used only with a specific objective, etc...

@tlambert03
Copy link
Member

is it possible to directly modify image pixel size? (doesn't look like it is yet). I don't think the user should be "forced" to use the camera pixel/mag math... If they know their image pixel size (which is the default interface in micromanager right?) they should be allowed to enter it

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Mar 9, 2022

@tlambert03 I think everything is working as it should now...

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Jul 10, 2022

closing since it has been moved to https://github.com/pymmcore-plus/pymmcore-widgets.

@fdrgsp fdrgsp closed this Jul 10, 2022
@tlambert03
Copy link
Member

did this feature specifically get implemented? If not, we shouldn't close the issue (but we can transfer it)

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Jul 10, 2022

@tlambert03 yes sorry, I've added it to pymmcore-widgets.

@tlambert03
Copy link
Member

Can you link the pr here so we can see it?

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Jul 10, 2022

@tlambert03 #141

@tlambert03
Copy link
Member

😂 ... that links to this PR. looking through your history, I'm guessing it was pymmcore-plus/pymmcore-widgets#6

If I recall, there were definitely some UI and organization-related questions remaining to be answered in this PR. Let's not merge un-discussed, un-reviewed things into the new repo. 🙏

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Jul 10, 2022

😂 sorry I didn't get that. yes that's the one. do you want me to reopen it in pymmcore-widgets?

I can remove the set_pixel_size_widget.py and the test if you want.

same for shutter_widget.py.

@tlambert03
Copy link
Member

No, just create issues reminding us as a group to evaluate them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants