create ExposureWidget as a core widget + properly connect exposure signals #150
Conversation
ianhi
changed the title
|
Test failure is unrelated: https://github.com/tlambert03/napari-micromanager/issues/153 so this is ready for review |
|
can you rebase on main? |
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 80.23% 80.66% +0.43%
==========================================
Files 23 24 +1
Lines 2054 2100 +46
==========================================
+ Hits 1648 1694 +46
Misses 406 406
Continue to review full report at Codecov.
|
|
@tlambert03 or @fdrgsp if you get a chance to look at this sometime that'd be great - the exposure not prefilling has been driving me nuts |
| g_Keyword_CoreDevice, g_Keyword_CoreCamera | ||
| ).connect(self._camera_updated) | ||
|
|
||
| def setCamera(self, camera: str = None, force: bool = False): |
There was a problem hiding this comment.
are you thinking of a use case for this? or just maybe nice to have? maybe "yagni"?
There was a problem hiding this comment.
Do you mean the method on ExposureWidget or the version on the DefaultCamera version?
There was a problem hiding this comment.
The one with the big warning on default cam... ah, but maybe I see now, it's already there in the superclass and you're just restricting it on the subclass?
Adds two new core widgets:
getCameraDevice) as closely as possible. Though not perfectly, seesetCameraDevicedoes not emit apropertyChangedevent micro-manager/mmCoreAndDevices#181There's also a bugfix in here. Previously if you loaded a config before opening napari then the exposure widget would not fill with the correct value - now it does.