Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor update _presets_widget.py #164

Closed
wants to merge 5 commits into from

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Apr 22, 2022

Set the group combobox to the current preset when the widget is created or refreshed.

This is important for PR #144 and #122

@fdrgsp fdrgsp changed the title minor update minor update _presets_widget.py Apr 22, 2022
@fdrgsp fdrgsp mentioned this pull request Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #164 (1bad737) into main (15a35cb) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 1bad737 differs from pull request most recent head df4ee83. Consider uploading reports for the commit df4ee83 to get more accurate results

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   81.83%   81.86%   +0.03%     
==========================================
  Files          26       26              
  Lines        2323     2316       -7     
==========================================
- Hits         1901     1896       -5     
+ Misses        422      420       -2     
Impacted Files Coverage Δ
micromanager_gui/_core_widgets/_presets_widget.py 83.15% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a35cb...df4ee83. Read the comment docs.

Co-authored-by: Ian Hunt-Isaak <ianhuntisaak@gmail.com>
@ianhi
Copy link
Contributor

ianhi commented May 19, 2022

probably good to add a test of this? otherwise looking good

@tlambert03
Copy link
Member

looks like this got added also in #167, so will close

@tlambert03 tlambert03 closed this May 19, 2022
@fdrgsp fdrgsp deleted the update_preset_widget branch May 27, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants