Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Explorer .ui gui file with .py #168

Merged
merged 15 commits into from
Jun 9, 2022

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented May 5, 2022

I recreated the sample_explorer gui widget in python and replaced the old .ui file.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #168 (4eb2e34) into main (b1b0b60) will increase coverage by 1.29%.
The diff coverage is 96.33%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   81.58%   82.88%   +1.29%     
==========================================
  Files          25       26       +1     
  Lines        2270     2448     +178     
==========================================
+ Hits         1852     2029     +177     
- Misses        418      419       +1     
Impacted Files Coverage Δ
..._sample_explorer_widget/_sample_explorer_widget.py 82.53% <80.00%> (ø)
...ts/_sample_explorer_widget/_sample_explorer_gui.py 97.08% <97.08%> (ø)
micromanager_gui/_gui_objects/_mm_widget.py 96.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b0b60...4eb2e34. Read the comment docs.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlambert03 tlambert03 merged commit 12b9808 into pymmcore-plus:main Jun 9, 2022
@fdrgsp fdrgsp deleted the explorer_gui_to_py branch May 27, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants