Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use pymmcore-widgets #188

Closed

Conversation

tlambert03
Copy link
Member

No description provided.

@tlambert03
Copy link
Member Author

ok, the main reason this is failing is that it's ending up with a different core instance. So now, we get to really experience the joys of singleton management 😂

it would be relatively easy to fix by not using a custom session core in our tests here, but I don't really want to do that yet. (it's nice to be able to use an isolated little core instance, particularly for tests). So we may have to either create a nice set_core context manager, that allows you to inject a given core instance (we could potentially use in-n-out here), or, we might need to laboriously pass the core instance around through all the widgets (ew)

@tlambert03
Copy link
Member Author

see #194 instead

@tlambert03 tlambert03 closed this Aug 7, 2022
@tlambert03 tlambert03 deleted the use-pymmcore-widgets branch December 4, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant