Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ROI camera widget fro pymmcore_widget #200

Closed
wants to merge 85 commits into from

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Oct 1, 2022

This PR adds the CameraRoiWidget widget from pymmcore_widgets.

With this PR we can control the camera ROI with a napari shape layer.

To be merged after pymmcore-plus/pymmcore-widgets#47.

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 84.74% // Head: 84.55% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (bbda016) compared to base (e183861).
Patch coverage: 62.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   84.74%   84.55%   -0.19%     
==========================================
  Files          16       14       -2     
  Lines        1796     1716      -80     
==========================================
- Hits         1522     1451      -71     
+ Misses        274      265       -9     
Impacted Files Coverage Δ
micromanager_gui/main_window.py 77.33% <54.38%> (-1.45%) ⬇️
micromanager_gui/_gui_objects/_mm_widget.py 96.90% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fdrgsp fdrgsp changed the title [WIP] feat: add ROI camera widget fro pymmcore_widget feat: add ROI camera widget fro pymmcore_widget Oct 1, 2022
@fdrgsp fdrgsp changed the title feat: add ROI camera widget fro pymmcore_widget [WIP] feat: add ROI camera widget fro pymmcore_widget Oct 1, 2022
@fdrgsp fdrgsp changed the title [WIP] feat: add ROI camera widget fro pymmcore_widget feat: add ROI camera widget fro pymmcore_widget Oct 10, 2022
@fdrgsp fdrgsp closed this Nov 9, 2022
@fdrgsp fdrgsp deleted the add_camROI_wdg branch May 27, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant