Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use all pymmcore-widgets #215

Merged
merged 7 commits into from
Nov 29, 2022

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Nov 28, 2022

First PR to break up #214.

In this PR, all the QtWidgets used in napari-micromanager are replaced by pymmcore-widgets (or pymmcore-widgets subclass) + fix/update tests.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 84.74% // Head: 86.11% // Increases project coverage by +1.37% 🎉

Coverage data is based on head (4ce92c2) compared to base (0a6d3a7).
Patch coverage: 92.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   84.74%   86.11%   +1.37%     
==========================================
  Files          16       12       -4     
  Lines        1796      922     -874     
==========================================
- Hits         1522      794     -728     
+ Misses        274      128     -146     
Impacted Files Coverage Δ
micromanager_gui/_gui_objects/_xyz_stages.py 61.97% <0.00%> (ø)
micromanager_gui/_saving.py 68.75% <59.25%> (-0.95%) ⬇️
micromanager_gui/_gui_objects/_mda_widget.py 92.04% <92.04%> (ø)
micromanager_gui/main_window.py 84.19% <94.18%> (+5.41%) ⬆️
...anager_gui/_gui_objects/_sample_explorer_widget.py 94.21% <94.21%> (ø)
micromanager_gui/_gui_objects/_mm_widget.py 97.19% <97.61%> (+0.25%) ⬆️
micromanager_gui/_gui_objects/_shutters_widget.py 100.00% <100.00%> (+18.51%) ⬆️
micromanager_gui/_gui_objects/_tab_widget.py 100.00% <100.00%> (+6.84%) ⬆️
micromanager_gui/_mda_meta.py 100.00% <100.00%> (ø)
micromanager_gui/_util.py 75.00% <100.00%> (+20.65%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of stuff here, great to remove all this code.

As discussed, will be great to get past the big refactor, then revisit all this stuff with a fine-toothed comb, adding tests, and refactoring out stuff.

thanks!

@tlambert03 tlambert03 merged commit ace5c7b into pymmcore-plus:main Nov 29, 2022
@fdrgsp fdrgsp deleted the use_all_pymmcore_widgets branch May 27, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants