-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use all pymmcore-widgets #215
feat: use all pymmcore-widgets #215
Conversation
Codecov ReportBase: 84.74% // Head: 86.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 84.74% 86.11% +1.37%
==========================================
Files 16 12 -4
Lines 1796 922 -874
==========================================
- Hits 1522 794 -728
+ Misses 274 128 -146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of stuff here, great to remove all this code.
As discussed, will be great to get past the big refactor, then revisit all this stuff with a fine-toothed comb, adding tests, and refactoring out stuff.
thanks!
First PR to break up #214.
In this PR, all the
QtWidgets
used innapari-micromanager
are replaced bypymmcore-widgets
(orpymmcore-widgets
subclass) + fix/update tests.