Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull minmax logic off main window, and reduce minmax widget layout logic #233

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Dec 6, 2022

puts the logic for updating minmax on the minmax widget itself, removing it from the main window. Also simplifies the layout down to a couple lines

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 85.26% // Head: 84.98% // Decreases project coverage by -0.28% ⚠️

Coverage data is based on head (8ae593e) compared to base (b6922ab).
Patch coverage: 92.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   85.26%   84.98%   -0.29%     
==========================================
  Files          14       14              
  Lines         991      979      -12     
==========================================
- Hits          845      832      -13     
- Misses        146      147       +1     
Impacted Files Coverage Δ
...apari_micromanager/_gui_objects/_min_max_widget.py 90.90% <90.90%> (-9.10%) ⬇️
src/napari_micromanager/main_window.py 94.28% <100.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tlambert03 tlambert03 merged commit 52f08ea into pymmcore-plus:main Dec 7, 2022
@tlambert03 tlambert03 deleted the minmax branch December 7, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant