refactor: big cleanup of MDAHandler logic #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.79% // Head: 84.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 84.79% 84.45% -0.35%
==========================================
Files 15 15
Lines 921 894 -27
==========================================
- Hits 781 755 -26
+ Misses 140 139 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of a number of mostly similar methods (with slightly different behavior for explorer vs mda):
and replaces them with two functions:
_determine_sequence_layers- a pure stateless function (i.e. not a class method) that takes asequenceobject, and returns information(id, shape, metadata)about all of the layers that need to be created for the experiment (based on whether C or P is being split. Being stateless is particularly nice here, since it means it can be tested completely in absence of a core, a widget, a viewer, etc... (but that will happen in a followup PR)_create_empty_image_layer- one method that creates the necessary layers.