Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fixes for new widgets #246

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Conversation

tlambert03
Copy link
Member

pins widgets to >0.3.0 and gets tests passing again.

Note @fdrgsp ... I'm just skipping the sample explorer tests here. Please fix those when you get a chance

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 84.35% // Head: 74.16% // Decreases project coverage by -10.19% ⚠️

Coverage data is based on head (b2580cf) compared to base (63a12e2).
Patch coverage: 59.25% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #246       +/-   ##
===========================================
- Coverage   84.35%   74.16%   -10.19%     
===========================================
  Files          16       16               
  Lines         901      871       -30     
===========================================
- Hits          760      646      -114     
- Misses        141      225       +84     
Impacted Files Coverage Δ
src/napari_micromanager/__main__.py 100.00% <ø> (ø)
src/napari_micromanager/_saving.py 55.93% <ø> (-16.95%) ⬇️
src/napari_micromanager/_mda_handler.py 72.79% <52.17%> (-25.37%) ⬇️
...rc/napari_micromanager/_gui_objects/_mda_widget.py 88.67% <100.00%> (-2.40%) ⬇️
...cromanager/_gui_objects/_sample_explorer_widget.py 57.33% <100.00%> (-40.01%) ⬇️
...c/napari_micromanager/_gui_objects/_save_widget.py 90.62% <100.00%> (ø)
src/napari_micromanager/_mda_meta.py 100.00% <100.00%> (ø)
...pari_micromanager/_gui_objects/_shutters_widget.py 89.18% <0.00%> (-10.82%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ianhi
Copy link
Contributor

ianhi commented Jan 19, 2023

nice!

@tlambert03 tlambert03 merged commit bdbd68a into pymmcore-plus:main Jan 20, 2023
@tlambert03 tlambert03 deleted the fix-widgets branch January 20, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants