Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent from manual editing the cells from the property browser table #73

Merged

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Nov 4, 2021

  • The "property" column in the Property Browser table contains the device_name and the device_property that can be changed using the widgets in the "value" column. The "property" column is currently editable (you can change/delete the content of the cell), I think it can be good to prevent that from happening (self.native.setEditTriggers(QtWidgets.QTableWidget.NoEditTriggers).

  • set the min_width of the Property Browser table

  • hide the verticalHeader() of the Property Browser table (row number)

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #73 (59a3fd3) into main (3ad1ed0) will decrease coverage by 4.44%.
The diff coverage is 100.00%.

❗ Current head 59a3fd3 differs from pull request most recent head 6f358db. Consider uploading reports for the commit 6f358db to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   60.92%   56.47%   -4.45%     
==========================================
  Files          11       11              
  Lines        1492     1312     -180     
==========================================
- Hits          909      741     -168     
+ Misses        583      571      -12     
Impacted Files Coverage Δ
micromanager_gui/prop_browser.py 79.02% <100.00%> (+0.76%) ⬆️
micromanager_gui/multid_widget.py 71.93% <0.00%> (-2.66%) ⬇️
micromanager_gui/main_window.py 68.67% <0.00%> (-0.96%) ⬇️
micromanager_gui/_camera_roi.py
micromanager_gui/install_mm.py 0.00% <0.00%> (ø)
micromanager_gui/explore_sample.py 68.80% <0.00%> (+0.22%) ⬆️
micromanager_gui/_util.py 57.57% <0.00%> (+3.03%) ⬆️
micromanager_gui/__init__.py 77.77% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad1ed0...6f358db. Read the comment docs.

@tlambert03
Copy link
Member

@fdrgsp ... please, please provide a brief sentence or two explaining your rationale whenever you open a PR, even if it feels self-explanatory. As is, I'm left to wonder "is this obvious? are these read-only anyway? ... or did he maybe come across a case where editing one that was theoretically editable didn't work when he tried?"

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Nov 4, 2021

sorry @tlambert03, description added.

@tlambert03 tlambert03 merged commit 4f9accb into pymmcore-plus:main Feb 24, 2022
@fdrgsp fdrgsp deleted the prevent_editing_prop_browser_cells branch May 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants