Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event emission when setting property on a state device #105

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Mar 4, 2022

fixes #104

also creates and moves some tests. The only new thing in the PR is the 6 lines in _mmcore_plus

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #105 (d71aa79) into main (2fcf5fc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   89.46%   89.48%   +0.02%     
==========================================
  Files          23       23              
  Lines        1035     1037       +2     
==========================================
+ Hits          926      928       +2     
  Misses        109      109              
Impacted Files Coverage Δ
pymmcore_plus/core/_mmcore_plus.py 89.17% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fcf5fc...d71aa79. Read the comment docs.

@tlambert03 tlambert03 merged commit 80ec072 into main Mar 4, 2022
@tlambert03 tlambert03 deleted the fix-state-prop-signals branch March 4, 2022 16:11
@tlambert03 tlambert03 added the bug Something isn't working label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant