Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky tests #114

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix flaky tests #114

merged 1 commit into from
Mar 10, 2022

Conversation

ianhi
Copy link
Collaborator

@ianhi ianhi commented Mar 10, 2022

Used to actually use core.run_mda but it seems like it impossible to get proper timing to not be inconsistent in CI.

Once this passes I will restart a few times to make sure i actually fixed it.

@ianhi ianhi closed this Mar 10, 2022
@ianhi ianhi reopened this Mar 10, 2022
@ianhi ianhi closed this Mar 10, 2022
@ianhi ianhi reopened this Mar 10, 2022
@ianhi ianhi linked an issue Mar 10, 2022 that may be closed by this pull request
@ianhi
Copy link
Collaborator Author

ianhi commented Mar 10, 2022

ok that's 3 consecutive passes. I think all is well now.

@ianhi ianhi merged commit f7a73c2 into pymmcore-plus:main Mar 10, 2022
@ianhi ianhi deleted the flaky branch March 10, 2022 17:09
@tlambert03
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests flaky again
2 participants