Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add phases to TimePlanWidget #132

Merged
merged 39 commits into from
May 18, 2023

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Mar 26, 2023

This PR adds to the TimePlanWidget the possibility to set useq-schema MultiPhaseTimePlan.


Screenshot 2023-03-26 at 5 05 26 PM

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage: 97.76% and project coverage change: +0.08 🎉

Comparison is base (2ebadea) 89.50% compared to head (789682b) 89.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   89.50%   89.59%   +0.08%     
==========================================
  Files          37       37              
  Lines        4918     4977      +59     
==========================================
+ Hits         4402     4459      +57     
- Misses        516      518       +2     
Impacted Files Coverage Δ
src/pymmcore_widgets/_mda/_time_plan_widget.py 97.05% <96.90%> (+3.58%) ⬆️
src/pymmcore_widgets/_mda/_mda_widget.py 93.44% <100.00%> (-0.04%) ⬇️
src/pymmcore_widgets/_util.py 75.34% <100.00%> (-0.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fdrgsp fdrgsp changed the title feat: add phases to TimePlanWidget feat: add phases to TimePlanWidget [WIP] Mar 30, 2023
@fdrgsp fdrgsp changed the title feat: add phases to TimePlanWidget [WIP] feat: add phases to TimePlanWidget Apr 2, 2023
@tlambert03
Copy link
Member

Pint can do all those unit conversions for you, see https://pyapp-kit.github.io/superqt/widgets/qquantity/

And pint quantity: https://pint.readthedocs.io/en/0.7.2/tutorial.html

So you shouldn't need timedelta_to_units ..,

@tlambert03 tlambert03 merged commit b8808f6 into pymmcore-plus:main May 18, 2023
16 checks passed
@fdrgsp fdrgsp deleted the advanced_time_widget branch February 6, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants