Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add micromanager autofocus device control autofocus #147

Merged
merged 335 commits into from
Jul 27, 2023

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Jun 30, 2023

This PR upgrades the PositionWidget and add the ability to control and use any Micromanager Autofocus device (e.g. Nikon PFS).

Linked to pymmcore-plus/useq-schema#91 and pymmcore-plus/pymmcore-plus#199.

followup to #128 and #133.


Screenshot 2023-06-30 at 12 14 08 PM

super().__init__(parent)

self._mmc = mmcore or CMMCorePlus.instance()
self._autofocus_device: str = self._mmc.getAutoFocusDevice() or ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 83.44% and no project coverage change.

Comparison is base (5caef4b) 89.58% compared to head (e7fc327) 89.58%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #147    +/-   ##
========================================
  Coverage   89.58%   89.58%            
========================================
  Files          37       38     +1     
  Lines        5029     5270   +241     
========================================
+ Hits         4505     4721   +216     
- Misses        524      549    +25     
Files Changed Coverage Δ
src/pymmcore_widgets/_mda/_mda_widget.py 89.16% <76.92%> (-0.70%) ⬇️
...c/pymmcore_widgets/_mda/_positions_table_widget.py 86.69% <79.61%> (+0.75%) ⬆️
.../pymmcore_widgets/_mda/_autofocus_device_widget.py 93.25% <93.25%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 closed this Jul 27, 2023
@tlambert03 tlambert03 reopened this Jul 27, 2023
@tlambert03 tlambert03 enabled auto-merge (squash) July 27, 2023 21:11
@tlambert03 tlambert03 merged commit 6193121 into pymmcore-plus:main Jul 27, 2023
18 of 19 checks passed
@fdrgsp fdrgsp deleted the with_autofocus branch February 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants