Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor time widget fix #153

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Jul 24, 2023

Fixing the _create_new_row method in TimePlanWidget so that we can pass 0.0 as a possible interval: adding if isinstance(interval, timedelta) instead of only if interval.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90706e6) 89.39% compared to head (d6fc795) 89.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files          37       37           
  Lines        4999     4999           
=======================================
  Hits         4469     4469           
  Misses        530      530           
Files Changed Coverage Δ
src/pymmcore_widgets/_mda/_time_plan_widget.py 96.35% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 76d833c into pymmcore-plus:main Jul 25, 2023
19 checks passed
@fdrgsp fdrgsp deleted the fix_time_wdg branch February 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants