Remove pre-commit (#1860)

Co-authored-by: Alex Ruddick <a.ruddick@numat-tech.com>

.github/workflows/ci.yml

@@ -66,8 +66,7 @@ jobs:
           path: ${{ env.VIRTUAL_ENV }}
           key: >-
             ${{ runner.os }}-${{ matrix.python }}-venv-${{
-              hashFiles('pyproject.toml') }}-${{
-              hashFiles('.pre-commit-config.yaml') }}
+              hashFiles('pyproject.toml') }}
 
       - name: Create venv (NEW CACHE)
         if: steps.cache-venv.outputs.cache-hit != 'true'
@@ -96,10 +95,10 @@ jobs:
         run: |
           mypy pymodbus
 
-      - name: precommit
+      - name: ruff
         if: matrix.run_lint == true
         run: |
-          pre-commit run --all-files
+          ruff .
 
       - name: pytest
         run: |

README.rst

@@ -191,23 +191,26 @@ or the bleeding edge::
 
    git checkout dev
 
+Some distributions have an old pip, which needs to be upgraded:
+
+   pip install --upgrade pip
+
 Install required development tools::
 
    pip install ".[development]"
-   pre-commit install
 
 Install all (allows creation of documentation etc):
 
    pip install ".[all]"
-   pre-commit install
 
+Install git hooks, that helps control the commit and avoid errors when submitting a Pull Request:
+
+  cp githooks/* .git/hooks
 
 This installs dependencies in your virtual environment
 with pointers directly to the pymodbus directory,
 so any change you make is immediately available as if installed.
 
-It will also install :code:`pre-commit` git hooks, ensuring your commit are verified.
-
 The repository contains a number of important branches and tags.
   * **dev** is where all development happens, this branch is not always stable.
   * **master** is where are releases are kept.

check_ci.sh

@@ -6,7 +6,7 @@ trap 'echo "\"${last_command}\" command filed with exit code $?."' EXIT
 
 
 codespell
-pre-commit run --all-files
+ruff check --fix --exit-non-zero-on-fix .
 pylint --recursive=y examples pymodbus test
 mypy pymodbus
 pytest --numprocesses auto

githooks/pre-commit

@@ -0,0 +1,6 @@
+#!/bin/sh
+
+# Redirect output to stderr.
+1>&2
+
+ruff check --fix --exit-non-zero-on-fix .

pyproject.toml

@@ -68,7 +68,6 @@ development = [
     "codespell>=2.2.2",
     "coverage>=7.1.0",
     "mypy>=1.6.0",
-    "pre-commit>=3.5.0",
     "pylint>=2.17.2",
     "pytest>=7.3.1",
     "pytest-asyncio>=0.20.3",