Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 with ruff #1476

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Replace flake8 with ruff #1476

merged 2 commits into from
Apr 7, 2023

Conversation

alexrudd2
Copy link
Collaborator

ruff is rapidly absorbing lots of linters. I used flake8-to-ruff to generate a config which basically matches the current flake8 configuration.

Integration of bandit is left for later, since it uses the rule names from flake8-bandit which are slightly different.

Note: HomeAssistant has already switched, although their rules are more strict so I did not copy them (yet).

@janiversen
Copy link
Collaborator

A couple of comments.
If it makes things simpler then please make a PR that changes from bandit to flake8-bandit.

Can you please ( if you have not already) the rules from HA, commented out, that way it is easier to activate when you find t8mr.

Now to the review

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one.

I just had one small comment.

ruff.toml Outdated Show resolved Hide resolved
@janiversen janiversen merged commit 1be1568 into dev Apr 7, 2023
@alexrudd2 alexrudd2 deleted the ruff branch April 7, 2023 19:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants