Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate implicit optional in simulator #1841

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Eliminate implicit optional in simulator #1841

merged 2 commits into from
Oct 18, 2023

Conversation

alexrudd2
Copy link
Collaborator

This eliminates another 3 implicit optional in the simulator.

Since we're already doing from __future__ import annotations, also eliminate

from typing import List
List[x]

in favor of just list[x]

janiversen
janiversen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@janiversen janiversen merged commit 32e4881 into dev Oct 18, 2023
1 check passed
@janiversen janiversen deleted the implicit-optional-simulator branch October 18, 2023 05:45
janiversen pushed a commit that referenced this pull request Oct 18, 2023
@alexrudd2 @janiversen
Eliminate implicit optional in simulator (#1841)
9494665
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexrudd2 @janiversen