Add connection exception to list of exceptions catpured in retries #2113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible when using a Modbus TCP connection that the connection is unexpectedly closed while writing to a register. This raises a
ConnectionException
that is not caught in the existingcatch
statement.Note: The retry is done in the
retry_on_empty
catchIt's possible that this type of exception should not be caught, and should instead raise an error as the connection should not close unexpectedly. If I misunderstood, feel free to decline the pull request