Merge pull request #1558 from pymor/irka-init-fix

IRKA initialization fixes

src/pymor/reductors/h2.py

@@ -65,7 +65,7 @@ def _check_rom0_params(self, rom0_params):
         elif isinstance(rom0_params, np.ndarray):
             assert rom0_params.ndim == 1
         elif isinstance(rom0_params, dict):
-            assert ('sigma', 'b', 'c') in rom0_params
+            assert {'sigma', 'b', 'c'} <= rom0_params.keys()
             assert isinstance(rom0_params['sigma'], np.ndarray)
             assert isinstance(rom0_params['b'], np.ndarray)
             assert isinstance(rom0_params['c'], np.ndarray)
@@ -77,7 +77,7 @@ def _check_rom0_params(self, rom0_params):
         elif isinstance(rom0_params, LTIModel):
             assert rom0_params.order > 0
             if hasattr(self.fom, 'order'):  # self.fom can be a TransferFunction
-                assert rom0_params < self.fom.order
+                assert rom0_params.order < self.fom.order
             assert rom0_params.dim_input == self.fom.dim_input
             assert rom0_params.dim_output == self.fom.dim_output
         else:

src/pymortests/reductors/__init__.py

@@ -0,0 +1,4 @@
+# This file is part of the pyMOR project (https://www.pymor.org).
+# Copyright pyMOR developers and contributors. All rights reserved.
+# License: BSD 2-Clause License (https://opensource.org/licenses/BSD-2-Clause)
+

src/pymortests/reductors/h2.py

@@ -0,0 +1,32 @@
+# This file is part of the pyMOR project (https://www.pymor.org).
+# Copyright pyMOR developers and contributors. All rights reserved.
+# License: BSD 2-Clause License (https://opensource.org/licenses/BSD-2-Clause)
+
+import numpy as np
+
+from pymor.models.iosys import LTIModel
+from pymor.reductors.h2 import IRKAReductor
+
+
+def test_irka():
+    A = np.array([[-1, 0], [0, -2]])
+    B = np.array([[1], [2]])
+    C = np.array([[2, 1]])
+    fom = LTIModel.from_matrices(A, B, C)
+    irka = IRKAReductor(fom)
+
+    rom = irka.reduce(1)
+    assert isinstance(rom, LTIModel) and rom.order == 1
+
+    rom = irka.reduce(np.array([1]))
+    assert isinstance(rom, LTIModel) and rom.order == 1
+
+    rom = irka.reduce({'sigma': np.array([1]),
+                       'b': np.array([[1]]),
+                       'c': np.array([[1]])})
+    assert isinstance(rom, LTIModel) and rom.order == 1
+
+    rom = irka.reduce(LTIModel.from_matrices(np.array([[-1]]),
+                                             np.array([[1]]),
+                                             np.array([[1]])))
+    assert isinstance(rom, LTIModel) and rom.order == 1