Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mpi helper classes #163

Merged
merged 35 commits into from Nov 9, 2015
Merged

Add mpi helper classes #163

merged 35 commits into from Nov 9, 2015

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 7, 2015

This pull request contains the mpi helper classes from the pymor-paper branch. Merging this will close #119.

sdrave and others added 26 commits October 7, 2015 10:17
@sdrave
[tools] add mpi helper module
1fad5c0
@sdrave
[vectorarrays] add mpi aware NumpyVectorArray
e2e8b1d
@sdrave
[vectorarrays] add MPIVectorArray
2fa2747
@sdrave
[tools.mpi] catch exceptions in event loop
e42d30d
@sdrave
[vectorarrays.mpi] add MPIDistributed, MPIForbidCommunication, MPILoc…
81d3ee6 
…alSubtypes mixins
@sdrave
[vectorarrays.mpi] remove leftover code
dac8ccf
@sdrave
[discretizations] start work on MPIDiscretization
d923fba
@sdrave
[vectorarrays.mpi] merge MPILocalSubtypes feature into MPIVectorArray
2c8c922
@sdrave
[vectorarrays.mpi] add MPIVector, MPIDistributedVector, MPIVectorForb…
faf2ddd 
…idCommunication
@sdrave
[tools.mpi] add 'parallel' attribute
349bce0
@sdrave
[vectorarrays] add MPIVectorArrayAutoComm, MPIVectorArrayNoComm, MPIV…
65d4c24 
…ectorAutoComm, MPIVectorNoComm

replacing MPIDistributed, MPIDistributedVector, MPIForbidCommunication,
MPIVectorForbidCommunication
@sdrave
[tools.mpi] small tweaks
39ad70b
@sdrave
[vectorarray.mpi] bugfix
ecff759
@sdrave
[operators] add MPIOperator
395bdbf
@sdrave
[discretizations] extend MPIDiscretization
2e4efc6
@renefritze @sdrave
[mpi] fix typo in wrapper
762dc75
@sdrave
[vectorarray] implement components,amax for MPIVectorArrayAutoComm
53bc199
@sdrave
[tools.mpi] allow to run script with command line options
7fd5189
@sdrave
[operators] add 'as_vector' to MPIOperator
fdde72a
@sdrave
[discretizations] add parameter_space to MPIDiscretization
7bc8e1b
@sdrave
[operators] some fixes for MPIOperator
c2d2d01
@sdrave
[tools.mpi] print tracebacks when catching exceptions on ranks
ce5372f
@sdrave
[tools.mpi] quit event loops when main script has finished
8c99b84
@sdrave
[tools.mpi] fix 'quit' call in __main__
cd03c9e
@sdrave
[vectorarray] fix MPIVectorArrayAutoComm.amax
74cc5de
@sdrave
[mpi] remove almost_equal from MPIVectorArray
29d03d9
@sdrave sdrave added this to the 0.4 milestone Oct 7, 2015
@sdrave
Copy link
Member Author

sdrave commented Oct 7, 2015

Before merging we should check if everything still works and if we are happy with the interfaces ...

ftalbrecht
ftalbrecht reviewed Oct 7, 2015
View reviewed changes
src/pymor/tools/mpi.py
HAVE_MPI = True

comm = MPI.COMM_WORLD
rank = rank = comm.Get_rank()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct and/or intended?

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.18% when pulling 29d03d9 on mpi_merge into 9f1b01d on master.

@sdrave
Copy link
Member Author

sdrave commented Oct 9, 2015

I have added some documenation for pymor.tools.mpi.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.21% when pulling 32557f4 on mpi_merge into b76df09 on master.

ftalbrecht
ftalbrecht reviewed Oct 9, 2015
View reviewed changes
src/pymor/tools/mpi.py

ipython console --existing file_name_printed_by_ipython.json

(Starting the IPython console directly will not work properly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the IPython (too much whitespace)

@ftalbrecht
Copy link
Contributor

Thx for the documentation. I did not test for functionality, apart from that I am happy...

@sdrave
Copy link
Member Author

sdrave commented Oct 9, 2015

I have fixed the documentation issues in pymor.tools.mpi and added docs for pymor.vectorarrays.mpi

@ftalbrecht
Copy link
Contributor

Also happy with the new documentation, thx!

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.18% when pulling a795ab3 on mpi_merge into b76df09 on master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.16% when pulling 7015744 on mpi_merge into b76df09 on master.

@sdrave
Copy link
Member Author

sdrave commented Nov 6, 2015

So I have finally documented pymor.discretizations.mpi. From my point of view, this is now ready to merge. It would be nice if we had some kind of tutorial document for using pyMOR with MPI discretizations, but I guess I have no time for this in the near future.
Anyway, it is probably more important to improve the dune-burgers-demo repo, add some main script which actually does model reduction and so on ..

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.15% when pulling a31d42c on mpi_merge into b76df09 on master.

@sdrave sdrave mentioned this pull request Nov 6, 2015
Closed
@landscape-bot
Copy link

Code Health
Repository health increased by 0.37% when pulling 493f49e on mpi_merge into 98b014e on master.

sdrave added a commit that referenced this pull request Nov 9, 2015
@sdrave
Merge pull request #163 from pymor/mpi_merge
a3b5e0d 
Add MPI helper classes
@sdrave sdrave merged commit a3b5e0d into master Nov 9, 2015
@sdrave sdrave deleted the mpi_merge branch November 9, 2015 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

merge mpi helper tools from pymor-paper branch
4 participants
@sdrave @landscape-bot @ftalbrecht @renefritze