Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnstructuredTriangleGrid #174

Merged
merged 5 commits into from Nov 6, 2015
Merged

Add UnstructuredTriangleGrid #174

merged 5 commits into from Nov 6, 2015

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Oct 19, 2015

This adds pymor.grids.unstructured.UnstructuredTriangleGrid as a base class for unstructured 2d grids with triangle reference elements, partially resolving #9.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.00% when pulling 319e6f3 on unstructured_grid into 3fa4adf on master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.00% when pulling 38fa988 on unstructured_grid into 3fa4adf on master.

@ftalbrecht
Copy link
Contributor

I will not have the time to look into the changes this week, but it looks good to me. Independently of the UnstructeredTraingleGrid I really like the changes concerning the bounding_box and the reference elements; I think

if grid.reference_element in (triangle, square):

is much nicer than

if isinstance(grid, (TriaGrid, RectGrid)):

@landscape-bot
Copy link

Code Health
Repository health increased by 0.00% when pulling e80122a on unstructured_grid into 3fa4adf on master.

sdrave added a commit that referenced this pull request Nov 6, 2015
Add pymor.grids.UnstructuredTriangleGrid
@sdrave sdrave merged commit 94ae188 into master Nov 6, 2015
@sdrave sdrave deleted the unstructured_grid branch November 19, 2015 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants