New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pH-IRKA #1835

Merged

pmli merged 21 commits into main from ph-irka

Apr 19, 2023

Contributor

Jonas-Nicodemus commented Dec 13, 2022

This PR implements the pH-IRKA algorithm (cf. GPBV12).

github-actions bot added the autoupdate label

sdrave added the pr:new-feature label

Jonas-Nicodemus requested a review from pmli

December 13, 2022 16:21

sdrave added this to the 2023.1 milestone

pmli reviewed

View reviewed changes

Member

pmli left a comment

The new __init__.py files are also missing copyright headers, but I can't add a comment inline.

src/pymor/reductors/ph/basic.py Outdated Show resolved Hide resolved

src/pymor/reductors/ph/basic.py Outdated Show resolved Hide resolved

src/pymor/reductors/ph/basic.py Show resolved Hide resolved

src/pymor/reductors/ph/ph_irka.py Show resolved Hide resolved

sdrave force-pushed the main branch 4 times, most recently from 18e66f2 to e80291b Compare

March 7, 2023 20:03

Jonas-Nicodemus mentioned this pull request

Refactorization of PHLTIModel to inherit from LTIModel and support Q matrix #1836

Merged

github-actions bot added infrastructure management labels

Member

pmli commented Mar 16, 2023

@Jonas-Nicodemus, it looks like there are too many commits now. It looks like main got cherry-picked on ph-irka. Do you want to try rebasing again? Otherwise, I can try to force-push a rebase.

HenKlei force-pushed the ph-irka branch from 71f9410 to e37d75b Compare

March 16, 2023 13:04

github-actions bot removed management infrastructure labels

Member

HenKlei commented Mar 16, 2023

@Jonas-Nicodemus, it looks like there are too many commits now. It looks like main got cherry-picked on ph-irka. Do you want to try rebasing again? Otherwise, I can try to force-push a rebase.

Already done ;-)

pmli self-requested a review

March 16, 2023 13:22

pmli reviewed

View reviewed changes

src/pymortests/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymordemos/phlti.py Outdated Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/basic.py Outdated Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/__init__.py Outdated Show resolved Hide resolved

pmli requested changes

View reviewed changes

Member

pmli left a comment

I added some comments above.

Contributor Author

Jonas-Nicodemus commented Mar 24, 2023

I implemented all comments.

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/basic.py Outdated Show resolved Hide resolved

src/pymor/reductors/ph/basic.py Outdated Show resolved Hide resolved

src/pymordemos/phlti.py Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

src/pymor/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

src/pymor/reductors/ph/ph_irka.py Show resolved Hide resolved

src/pymor/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

pmli reviewed

View reviewed changes

src/pymor/reductors/ph/ph_irka.py Outdated Show resolved Hide resolved

Member

pmli commented Apr 19, 2023

pre-commit.ci autofix

Jonas-Nicodemus and others added 21 commits

April 19, 2023 15:56


          [reductors.ph] implement PHLTIPGReductor

1fa8d29


          [reductors.ph.ph_irka] implement PHIRKAReductor

51d2e88


          [pymordemos.phlti] update demo to reduce the msd model with pHIRKA

cb0c386


          [pymortests.reductors.ph] implement test for pH-IRKA

8d42f9d


          [pymor.reductors.ph.ph_irka] add pH-IRKA citation

a88b07b


          Update src/pymor/reductors/ph/basic.py

c043109

Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>


          [reductors.ph] add copyright header

bcec2a7


          Update src/pymortests/reductors/ph/ph_irka.py

99b6d63

Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>


          Update src/pymor/reductors/ph/basic.py

403426e

Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>


          [reductors.ph] add copyright header to init file.

59d63a8


          [reductors.ph.basic] remove _obtain_W

2afb944


          [pymordemos.phlti] add r as input to main

49e5086


          [reductors.ph.ph_irka] remove force_sigma_in_rhp parameter, since pH …

29dbde8

…systems are guaranteed to be stable


          Update src/pymor/reductors/ph/basic.py

6c6b934

Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>


          [pymortests.demos] remove argument for phlti demo

d01a5ec


          [reductors.ph.basic] add empty line at the end of file

37da572


          [reductors.ph.ph_irka] fix docstring and use only keyword arguments w…

ce7072c

…hen reduce is called


          Update src/pymor/reductors/ph/ph_irka.py

3bd39bf

Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>


          [reductors.ph.ph_irka] fix docstring

2b4bf36


          [reductors.ph.ph_irka] implement PR review

b7a20fc


          [pre-commit.ci] auto fixes from pre-commit.com hooks

30d2a07

for more information, see https://pre-commit.ci

pmli force-pushed the ph-irka branch from 8026c53 to 30d2a07 Compare

April 19, 2023 19:56

pmli enabled auto-merge

April 19, 2023 21:30

pmli approved these changes

View reviewed changes

pmli merged commit e5f4313 into main

25 checks passed

pmli deleted the ph-irka branch

April 19, 2023 22:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment