Adding Log Sampling #1940
Merged
Adding Log Sampling #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renefritze
previously requested changes
Jan 24, 2023
There was a problem hiding this comment.
Hey @Congpy thank you for your contribution. I made some style suggestions.
It would be great if the new sampling methods could be exercised in our test suite.
pmli
reviewed
Jan 25, 2023
sdrave
requested changes
Feb 13, 2023
sdrave
force-pushed
the
main
branch
4 times, most recently
from
18e66f2
to
e80291b
Compare
…thods under ParameterSpace class.
for more information, see https://pre-commit.ci
Co-authored-by: René Fritze <47802+renefritze@users.noreply.github.com>
Co-authored-by: René Fritze <47802+renefritze@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…mented to sample_logarithmic_randomly.
for more information, see https://pre-commit.ci
sdrave
approved these changes
Jun 7, 2023
|
Local mirror branch external_pr_1940 deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is my code regarding the #1598.
sample_logarithmic_randomly()is just like a random but scaled on a log scale.sample_logarithmic_uniformly()does whatsample_uniformly()does but on a log scale.PS: I'm sorry I cannot add new feature label. Maybe I should have done it before I opened the pr?