Refactoring pH and matrix solvers #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
sdrave
reviewed
Sep 25, 2023
pmli
reviewed
Sep 27, 2023
|
Hi @steff-mueller, do you have time to work on this before the hard freeze (Nov 30)? |
Then we can assume that the solution X to the Riccati equation is nonsingular.
…atrices can still be exported if a child class overrides `to_matrices` (like for instance `PHLTIModel`) - add `format` parameter to to_matrices methods
…ing the matrices individually
for more information, see https://pre-commit.ci
Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>
steff-mueller
force-pushed
the
refactor-ph
branch
from
425816e
to
13fb51e
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pmli
reviewed
Nov 27, 2023
Co-authored-by: Petar Mlinarić <mlinaric@vt.edu>
pmli
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve_pos_ricc_denseand bindings forscipyandslycotpr_c_denseandpr_o_denseGramianspr_o_denseGramian instead ofpr_o_lrcfbecause we need the full dense solution anywayfrom_passive_LTIModelinstead of lrcf onesto_abcde_matricestoLTIModelsuch that the standard ABCDE matrices can still be exported if a child class overridesto_matrices(like for instancePHLTIModel)formatparameter toto_matricesmethodsLTIModel.to_abcde_matricesinstead of converting the matrices individually