Python 3 #249
Merged
Python 3 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in py3 check_output defaults to opening stdout as a binary stream -> returned string is binary data string
type(None) is mandated in pep294
MethodType in python 3 only accepts two arguments and the instance cannot be None. I've reimplemented what I thought was the previous code's intention. Please confirm/correct @sdrave
I got 'size' being NoneType instance, which failed the comparison. There might be a underlying change in how the sqlite api behaves in py3, but this change seems to make it work for now (tm).
This is no longer necessarily true when the size is a np.int64.
More precisely a patched pyevtk available at https://bitbucket.org/dmitryew/pyevtk This seems to work with TriaGrid, but not RectGrid yet. refs #128, #134
this'll only execute "not_slow" marked pytests
this marks demo tests xfail iff pyside's not available and PySideMissing was raised
this includes np.int64
[build] change suggested pip command to install packeges one by one
[build] fix import name for pyside
this is still somewhat hacky, but I've no better idea atm. @sdrave maybe?
This leaves a file called '3to2.conversion.ok' next to setup.py after the conversion is complete. Also removes duplicated code in 3to2.sh
to prevent timeouts on travis
This fixes a pip install into a clean virtualenv with older setuptools versions. (Prepending 3to2 seems to ensure that numpy is installed first, which is necessary for some unknown reason.)
|
Ok, so I believe we have finally fixed all obvious issues with the python3 branch. If no one objects, I will merge to master on Friday. Any objections, @renemilk, @ftalbrecht, @andreasbuhr, @pmli? |
|
Great! :-) |
|
No objections :) |
|
None from my side.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.