Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new_type argument to with_ #705

Merged
merged 2 commits into from Jun 12, 2019
Merged

Add new_type argument to with_ #705

merged 2 commits into from Jun 12, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jun 11, 2019

No description provided.

@sdrave sdrave added pr:new-feature implementation labels Jun 11, 2019
@sdrave sdrave added this to the 2019.2 milestone Jun 11, 2019
@sdrave sdrave requested review from renefritze and pmli Jun 11, 2019
Copy link
Member

@renefritze renefritze left a comment

Did you have a real use case in mind for this?

g2 = g.with_(new_type=TriaGrid, domain=([0, 0], [2, 2]))

assert g2.num_intervals == (99, 99)
assert np.all(g2.domain == ([0, 0], [2, 2]))
Copy link
Member

@renefritze renefritze Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test could be better if it checks if g2 is of the right type.

pmli
pmli approved these changes Jun 12, 2019
@sdrave sdrave merged commit e07cc04 into master Jun 12, 2019
7 checks passed
@sdrave sdrave deleted the with_type branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants