New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add second order partial derivatives w.r.t. parameters #840
Conversation
@TiKeil, can you rebase on current master? This should hopefully make CI pass. Can you argue why it is better to have a dedicated method for the second derivatives instead of calling |
Codecov Report
|
This is actually a good point. I think there is no particular reason for having a second method although I find 'd_mui_muj' a little bit more intuitive to call. |
I removed d_mui_muj in f74b059 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I added the changes and rebased on master |
In this PR, I expand the first order derivatives w.r.t parameters as done in #748 to second order partial derivatives.
I more or less edited the same amount of code as in #748 and I adapted the test to it.
I went for the name "second_derivative". Another idea was to call it hessian, but this is a little bit dependent on the application I guess. With the code, it is also possible to only give a few expressions and not all.
Any objections ?