Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.pyx files should not be installed #142

Closed
Arfrever opened this issue Dec 5, 2013 · 2 comments
Closed

*.pyx files should not be installed #142

Arfrever opened this issue Dec 5, 2013 · 2 comments
Assignees

Comments

@Arfrever
Copy link

Arfrever commented Dec 5, 2013

setup.py installs /usr/_mssql.pyx and /usr/pymssql.pyx due to the following lines:

    data_files = [
        ('', ['_mssql.pyx', 'pymssql.pyx'])
    ],

They were added in commit 7346cc1 whose commit message says "include the *.pyx files when distributing".

The correct solution is to use MANIFEST.in.

--- setup.py
+++ setup.py
@@ -442,9 +442,6 @@
       "Operating System :: POSIX",
       "Operating System :: Unix",
     ],
-    data_files = [
-        ('', ['_mssql.pyx', 'pymssql.pyx'])
-    ],
     zip_safe = False,
     tests_require=['nose', 'unittest2'],
     test_suite='nose.collector',
--- MANIFEST.in
+++ MANIFEST.in
@@ -2,6 +2,7 @@
 include ChangeLog
 include LICENSE
 include *.pxd
+include *.pyx
 include *.c
 include *.rst
 include win32/freetds.zip
@msabramo
Copy link
Contributor

msabramo commented Dec 5, 2013

@Arfrever: Thank you!

I've noticed that we have those pyx files in the roots of our virtualenvs but never bothered to look into why. This is probably why. I'll try to take a look at this soon. Thanks again!

@ghost ghost assigned msabramo Dec 9, 2013
@msabramo
Copy link
Contributor

msabramo commented Dec 9, 2013

Thanks again, @Arfrever!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants