Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing py27 Linux wheel for 1.17.0 release #511

Closed
stephenfin opened this issue May 20, 2020 · 10 comments
Closed

Missing py27 Linux wheel for 1.17.0 release #511

stephenfin opened this issue May 20, 2020 · 10 comments
Assignees
Labels
bug upstream bug bug outside this package

Comments

@stephenfin
Copy link

Per title, there does not appear to be a PyMuPDF-1.17.0-cp27-cp27m-manylinux2010_x86_64.whl wheel published to PyPI. This necessitates building from source. I tried to figure out where these are built, so I could determine if there was a build failure or this was intentional, but I was unable to do so 😞

@stephenfin stephenfin added the bug label May 20, 2020
@stephenfin stephenfin changed the title Missing py27 wheel for 1.17.0 release Missing py27 Linux wheel for 1.17.0 release May 20, 2020
@JorjMcKie
Copy link
Collaborator

I did not intend to discriminate users of outdated Python versions 😎
But Travis CI, which does the wheel building, has issues these days.
I just built a Python2 version on my machine (Ubuntu). If you want I can supply a zip of the corresponding fitz folder via this channel.

@JorjMcKie
Copy link
Collaborator

Ok here is comes.
lib.linux-x86_64-2.7.zip

@JorjMcKie
Copy link
Collaborator

I will check with Travis from time to time and publish the missing wheel as soon as it is working agian.

@stephenfin
Copy link
Author

I did not intend to discriminate users of outdated Python versions sunglasses
But Travis CI, which does the wheel building, has issues these days.
I just built a Python2 version on my machine (Ubuntu). If you want I can supply a zip of the corresponding fitz folder via this channel.

Awesome! Would it be possible to push a manually built wheel to PyPI? I spotted this issue when trying to figure out why rst2pdf/rst2pdf#854 failed on Python 2.7 so I'd like to resolve that.

@JorjMcKie
Copy link
Collaborator

Would it be possible to push a manually built wheel to PyPI?

Maybe ... somehow I suppose. After all I am building Windows wheels with a handmade script directly on my machine.
The issue with any such handcrafted wheel would be, that it is not tagged manylinux, so only works for Ubuntu-like systems I guess.
As a Windows freak I have to wipe a sarcastic smile from my face, when I think about the portability of Linux systems ... 😂😂😂

@stephenfin
Copy link
Author

Oh, indeed, that's certainly not trivial. Based on this project, it seems you should be able to do the following from the root of the pacakge to build the package:

wget https://raw.githubusercontent.com/pypa/python-manylinux-demo/master/travis/build-wheels.sh
docker run --rm -e PLAT=manylinux1_x86_64 -v `pwd`:/io quay.io/pypa/manylinux1_x86_64 /io/build-wheels.sh

...but I notice that we're not using setuptools (and maybe can't) so I've really no idea 😄

@stephenfin
Copy link
Author

I guess let's just wait on Travis, as you suggest

@JorjMcKie
Copy link
Collaborator

Further investigation showed that the issue is (1) confined to Linux Python 2.7 (tags cp27m and cp27mu), and (2) caused by auditwheel repair - not by Travis CI nor by cibuildwheel itself.

I submitted an issue to the auditwheel repo.

@JorjMcKie JorjMcKie added the upstream bug bug outside this package label May 23, 2020
@JorjMcKie
Copy link
Collaborator

In the end it turned out it was a PIP v20.1 issue.
I modified the build script for cibuildwheel so that the newest PIP would be used.
This solved the issue, and the Linux Py2.7 wheels are upload to PyPI.

@stephenfin
Copy link
Author

Thanks for investigations on this!

stephenfin added a commit to stephenfin/rst2pdf that referenced this issue Jun 2, 2020
It seems there are issues with the Python 2.7 wheels for PyMuPDF [1]. We
could wait for a fix, but given the next version of rst2pdf is expected
to be Python 3 only it's as easy to just drop testing for this now.

[1] pymupdf/PyMuPDF#511

Signed-off-by: Stephen Finucane <stephen@that.guru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream bug bug outside this package
Projects
None yet
Development

No branches or pull requests

2 participants