-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom regex for index parsing #224
Conversation
…scanId=x as scan number
- if groups in id can't be machted, return empty id_dict - if first scan is not an integer, set first scan to 0 - remove debug print function - if no integer in spec_id, return full id string
Codecov Report
@@ Coverage Diff @@
## dev #224 +/- ##
==========================================
+ Coverage 83.99% 84.15% +0.16%
==========================================
Files 32 32
Lines 3673 3698 +25
==========================================
+ Hits 3085 3112 +27
+ Misses 588 586 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Remove debug code (that's commented out) and then it should be ready to go.
…ymzml/pymzml into feature/custom_regex_for_index_parsing
Fix bugs when parsing files with non numerical id