Improve first iteration logic #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improving the first iteration logic in `PageIterator` and `ResultIterator`. Both iterators had a `_first_iteration` state attribute that could be replaced with better logic: - In `PageIterator`, it can be replaced with `_is_last_page` which - is exception-safe (only mutate after we do I/O), and - (IMO) more directly relates to the state we're handling - In `ResultsIterator`, we can do without `_first_iteration` (but we should initialize `_index` and `_count`) Inspired by #1059.
ikonst
changed the title
garrettheel
approved these changes
Nov 26, 2022
|
Got to update release notes and bump version before merging. |
ikonst
force-pushed
the
2022-11-25-backport-1101
branch
from
38a0f05
to
7f33545
Compare
ikonst
force-pushed
the
2022-11-25-backport-1101
branch
from
7f33545
to
a387b31
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #1101 to 5.x branch to allow handling an exception raised when retrieving the first item.
This was reported by a user (our retry mechanism apparently doesn't kick in).