Fix updating set to empty #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
force-pushed
the
07-11-update-set-to-empty
branch
from
f40bb99
to
b13dc6e
Compare
|
@jmphilli are you still dynamo-ing? |
|
@ikonst Reviewing |
pynamodb/expressions/operand.py
Outdated
| @@ -298,9 +298,12 @@ def __getitem__(self, item: Union[int, str]) -> 'Path': | |||
| def __or__(self, other): | |||
| return _IfNotExists(self, self._to_operand(other)) | |||
|
|
|||
| def set(self, value: Any) -> SetAction: | |||
| def set(self, value: Any) -> Union[SetAction, RemoveAction]: | |||
| # Returns an update action that sets this attribute to the given value | |||
There was a problem hiding this comment.
Comment: "Sets/removes" attribute
anandswaminathan
approved these changes
Jul 17, 2023
ikonst
commented
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #962.
Empty sets are not supported by DynamoDB. Currently we're representing empty sets by unsetting the attribute (hence it's indistinguishable from unsetting), i.e.
then
Another way to empty the set should be through an update expression:
We're not changing this semantic here, but we're making it so that
m1.update([MyModel.my_set.set([]))doesn't crash in botocore.When preparing an update expression, we've been sending update expressions like
{':0': {'NS': None}}which crashed botocore with "TypeError: 'NoneType' object is not iterable". The PR addresses it by using aREMOVEaction when assigning an empty value to a set.