Use attr.get_value(value) when deserialize #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add some tests? |
betamoo
commented
Feb 28, 2018
| assert True == LBAModel.get('pkey1').flag | ||
| assert False == LBAModel.get('pkey2').flag | ||
| assert None == LBAModel.get('pkey3').flag | ||
|
|
There was a problem hiding this comment.
Without the change, update_item will throw TypeError: expected string or buffer
betamoo
commented
Feb 28, 2018
| assert True == LBAModel.get('pkey1').flag | ||
| assert False == LBAModel.get('pkey2').flag | ||
| assert None == LBAModel.get('pkey3').flag | ||
|
|
There was a problem hiding this comment.
Without the change, update will throw TypeError: expected string or buffer
jeremypian
reviewed
Feb 28, 2018
|
|
||
|
|
||
| @pytest.mark.ddblocal | ||
| def test_legacy_boolean_attribute_deserialization_compatibility(ddb_url): |
There was a problem hiding this comment.
you can probably pytest.mark.parametrize those two tests
|
+1 |
jeremypian
reviewed
Feb 28, 2018
| assert None == BAModel.get('pkey3').flag | ||
|
|
||
| # Update a value in the model causing BooleanAttribute to be deserialized | ||
| BAModel.get('pkey1').update(actions=[BAModel.value.set('value2')]) |
There was a problem hiding this comment.
would it make sense to perform this set of updates on top of fresh LBAModel saves, instead of after update_item calls? technically update_item could correct the issue for the item, and the update calls would succeed even without the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change update & update_item to use attr.get_value(value) in deserialization.
The PR #149 introduced
attr.get_value(value)for backward compatibility between LBA and BA, and used it inmodel.from_raw_databut not inmodel.update_item(normodel.update) causing code like https://gist.github.com/betamoo/1fb15692d6fa74b9ddacfd4965632b26 to fail