Improve typing in expressions module. #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinner-lyft
force-pushed
the
expression-typing
branch
2 times, most recently
from
100b155
to
fc5a603
Compare
jpinner-lyft
force-pushed
the
expression-typing
branch
from
fc5a603
to
5af8b9b
Compare
ikonst
reviewed
Sep 17, 2020
| from pynamodb.attributes import Attribute | ||
| from pynamodb.expressions.operand import Path | ||
| from pynamodb.expressions.util import substitute_names | ||
|
|
||
|
|
||
| def create_projection_expression(attributes_to_get, placeholders): | ||
| def create_projection_expression(attributes_to_get, placeholders: Dict[str, str]) -> str: |
There was a problem hiding this comment.
that comes from connection base where it's typed as Optional[Any] -- so far I've inferred its:
Union[List[Attribute], List[Path], List[str], Attribute, Path, str]
but I was going to punt on it for now
ikonst
reviewed
Sep 17, 2020
ikonst
reviewed
Sep 17, 2020
ikonst
reviewed
Sep 17, 2020
| @@ -44,10 +44,6 @@ def __repr__(self): | |||
| values = [str(value) for value in self.values] | |||
| return self.format_string.format(*values, operator=self.operator) | |||
|
|
|||
| def __nonzero__(self): | |||
ikonst
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.