Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDTree enhancements #769

Merged
merged 39 commits into from
Feb 19, 2024
Merged

KDTree enhancements #769

merged 39 commits into from
Feb 19, 2024

Conversation

apontzen
Copy link
Member

@apontzen apontzen commented Feb 11, 2024

A number of KDTree enhancements have become necessary for future projects:

  • Make KDTree use npy_intp or equivalent for its indexing, which will be 64-bit on modern platforms so that larger files can be processed
  • Add ability to query spheres using the KDTree for speed
  • Reinstate parallel build of KDTree (it was previously found to be slow in ~2014, but unclear why this was - on modern machines seems like it works pretty well albeit not quite linearly)
  • Enable KDTrees to be built in shared memory for tangos
  • Move KDTree into its own module, to reflect it now won't only be used for SPH
  • Switch to C++11 threading model, remove dependence on pthread

Longer-term required actions have been migrated into #770

@apontzen apontzen marked this pull request as draft February 11, 2024 08:25
@apontzen apontzen mentioned this pull request Feb 12, 2024
@apontzen apontzen marked this pull request as ready for review February 19, 2024 14:13
@apontzen apontzen merged commit 724076d into master Feb 19, 2024
15 checks passed
@apontzen apontzen deleted the kdtree-sphere branch February 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant