You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CI tests report success for MOAB & DAGMC stages even if MOAB is not found.
Because PyNE has been written to be compliant, it gracefully continues to build even if MOAB is not present/found. Relevant unit tests are configured to be skipped if MOAB/DAGMC are not found, and thus don't report failure.
We need to establish a test regimen that results in failure if MOAB is not found. Perhaps a build option to make MOAB "REQUIRED"?
I have already fixed these issues in the scikit-build-core branch. I also added new features to download optional packages if users requested them. I am now working on solving #1536, and after that, I hope all the tests will pass on my branch and ready to make a new PR on the develop branch.
We should update our setup/build process to make MOAB and DAGMC required if they are requested at build time - should only require a small change to CMakeLists.txt
I have already addressed this in #1526. I also believe we need to update the FindMOAB file as well to support the latest version of MOAB. Please let me know how you would like to proceed.
Describe the Bug
CI tests report success for MOAB & DAGMC stages even if MOAB is not found.
Because PyNE has been written to be compliant, it gracefully continues to build even if MOAB is not present/found. Relevant unit tests are configured to be skipped if MOAB/DAGMC are not found, and thus don't report failure.
We need to establish a test regimen that results in failure if MOAB is not found. Perhaps a build option to make MOAB "REQUIRED"?
See #1537 for user experience.
The text was updated successfully, but these errors were encountered: