You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there are a lot of rate caching functions that were added for the sensitivity logic. These also only need a list of rates and can likely be removed to their own module. We can store the cache arrays in their own class. This includes: calc_count_matrices(), update_rate_coef_arr(), update_yfrac_arr(), update_prefac_arr(), evaluate_rates_arr(), evaluate_ydots_arr(), evaluate_activity_arr(), clear_arrays() (done in Pull the vectorized rate evaluation functions into a separate NumpyNetwork #684)
we can change RateCollection to only take a Library -- this makes more sense in terms of the workflow we use for creating networks
we can make _build_collection a decorator
the precedence logic and _make_distinguishable() should be moved to Library. This is consistent with the new workflow that a RateCollection is created with a Library that has no duplicate links (done in remove the precedence logic from the RateCollection constructor #673)
The text was updated successfully, but these errors were encountered:
RateCollection
has gotten quite big and is hard to read now. I think that we can remove some things.get_screening_map
function really only needs a list of rates and can be extracted. This is done in PR move some screening utils out of RateCollection #666calc_count_matrices()
,update_rate_coef_arr()
,update_yfrac_arr()
,update_prefac_arr()
,evaluate_rates_arr()
,evaluate_ydots_arr()
,evaluate_activity_arr()
,clear_arrays()
(done in Pull the vectorized rate evaluation functions into a separate NumpyNetwork #684)NSENetwork
(done in separate NSE stuff into its own NSENetwork #675)RateCollection
to only take aLibrary
-- this makes more sense in terms of the workflow we use for creating networks_build_collection
a decoratorprecedence
logic and_make_distinguishable()
should be moved toLibrary
. This is consistent with the new workflow that aRateCollection
is created with aLibrary
that has no duplicate links (done in remove the precedence logic from the RateCollection constructor #673)The text was updated successfully, but these errors were encountered: