Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate NSE stuff into its own NSENetwork #675

Merged
merged 9 commits into from Oct 31, 2023
Merged

separate NSE stuff into its own NSENetwork #675

merged 9 commits into from Oct 31, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 29, 2023

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@zingale zingale mentioned this pull request Oct 29, 2023
Closed
4 tasks
@zingale zingale mentioned this pull request Oct 29, 2023
Merged
yut23
yut23 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the diffs in the notebooks are from #664.

@zingale
Copy link
Member Author

zingale commented Oct 30, 2023

oh that's interesting. I assume so too...

@zingale zingale merged commit 4e285d6 into pynucastro:main Oct 31, 2023
9 checks passed
@zingale zingale deleted the spin_off_nse_network branch October 31, 2023 12:52
@yut23 yut23 mentioned this pull request Nov 7, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zingale @yut23