Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate some notebooks #280

Merged
merged 4 commits into from
May 10, 2022
Merged

regenerate some notebooks #280

merged 4 commits into from
May 10, 2022

Conversation

zingale
Copy link
Member

@zingale zingale commented May 5, 2022

this also adds in a plot types documentation page
and fixes the formatting of the network charts

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yut23
Copy link
Collaborator

yut23 commented May 9, 2022

I've tracked down the pytest failures to a DPI mismatch, related to matplotlib/matplotlib#23007. The matplotlib-inline backend that Jupyter uses sets rcParams['figure.dpi'] to 72 when it's loaded, which used to be at import, but matplotlib 3.5.2 now defers that to the first time a figure is created.

@zingale
Copy link
Member Author

zingale commented May 10, 2022

oh good catch. I'll just update to 3.5.2 on my machine then and regenerate.

@zingale zingale merged commit 1814d36 into main May 10, 2022
@zingale zingale deleted the docs_update branch May 10, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants