New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add neutrino cooling routines #628
Conversation
this will allow us to compute ignition curves
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
okay there are unit tests and documentation now. I think this is ready for review. Note: I reorganized the docs a bit -- making more sections. I anticipate the NSE and neutrino sections growing as we add more discussions there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone else can also double check if needed.
It's probably a good idea to pull the different contributions out into helper functions/closures. That should limit the scope of the temporary variables, and help pylint figure out what's unused. |
I think I removed all the terms Zhi flagged I agree that this needs to be refactored, but I wanted to get something in and tested before doing that. I'd like to do the same with the C++ version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more
updated |
def zfermim12(x): | ||
"""apply a rational function expansion to get the fermi-dirac | ||
integral of order -1/2 evaluated at x. maximum error is 1.23e-12_rt. | ||
reference: antia apjs 84,101 1993""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this entire function can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
fixed the remaining ones |
this will allow us to compute ignition curves