Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the docs on data sources #679

Merged
merged 5 commits into from Nov 1, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 31, 2023

everything is now in the end
added info about Langanke rates, spins, and partition functions
also clean up the description of the weak rate tables
finally, enable dollarmath

everything is now in the end
added info about Langanke rates, spins, and partition functions
also clean up the description of the weak rate tables
finally, enable dollarmath
@zhichen3
Copy link
Collaborator

zhichen3 commented Oct 31, 2023

aside from the missing rate_types file, we should also update the data sources section in intro.rst

@zingale
Copy link
Member Author

zingale commented Oct 31, 2023

fixed.

I removed data sources entirely from intro.rst. Best to have it only in one place

@yut23
Copy link
Collaborator

yut23 commented Oct 31, 2023

Do we want to switch to bibtex for the references?

@zingale
Copy link
Member Author

zingale commented Oct 31, 2023

I think we should, but I need to look to see how they work inside of a Jupyter notebook, since sometimes we reference there. So I'd like to do that as a separate PR

@yut23
Copy link
Collaborator

yut23 commented Oct 31, 2023

Sure, that makes sense

@zingale zingale merged commit a7874a0 into pynucastro:main Nov 1, 2023
9 checks passed
@zingale zingale deleted the update_data_source_docs branch November 1, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants