Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maturin 1.5 as backend breaks poetry add #1988

Closed
2 tasks done
brettc opened this issue Mar 8, 2024 · 2 comments
Closed
2 tasks done

maturin 1.5 as backend breaks poetry add #1988

brettc opened this issue Mar 8, 2024 · 2 comments

Comments

@brettc
Copy link

brettc commented Mar 8, 2024

Bug Description

poetry (and perhaps others not tested) cannot install a package that has maturin 1.5 as a backend.

So, with this in my pyproject.toml, I cannot install the package, as it selects maturin 1.5. Poetry reports:
Unable to create package with no name

[build-system]
requires = ["maturin>=1.2,<2.0"]
build-backend = "maturin"

If I change it this line, it works:
requires = ["maturin>=1.2,<1.5"]

Your maturin version (maturin --version)

1.5

Your Python version (python -V)

3.12.2

Your pip version (pip -V)

23.3.2

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

Make sure you have the latest poetry and rye installed.
Do this in a shell:

# create a python and a python/maturin project
poetry new snake
rye init oxide --build-system maturin

# add the maturin project as a dependency
cd snake
poetry add ../oxide

# Fail

To fix it, change the line ["maturin>=1.2,<1.5"]
Now the poetry add will work.

@brettc brettc added the bug Something isn't working label Mar 8, 2024
@brettc brettc changed the title maturin 1.5 as backend breaks poetry install maturin 1.5 as backend breaks poetry add Mar 8, 2024
@messense
Copy link
Member

Probably because Poetry doesn't support metadata 2.3?

@konstin
Copy link
Member

konstin commented Mar 18, 2024

Fixed upstream in python-poetry/poetry#9130

@konstin konstin closed this as completed Mar 18, 2024
@messense messense removed the bug Something isn't working label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants