Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase supported python version to >=3.7.0 #1330

Closed
wants to merge 2 commits into from
Closed

Increase supported python version to >=3.7.0 #1330

wants to merge 2 commits into from

Conversation

dvzrv
Copy link
Contributor

@dvzrv dvzrv commented Feb 9, 2022 •
edited

Increase supported python version to >= 3.7.0

@flit
Copy link
Member

flit commented Feb 13, 2022

Is there a reason to not support Python 3.6? I actually need it for one of the projects I work on due to the OS version and available packages. So I suspect other users also still need it.

@flit
Copy link
Member

flit commented Feb 13, 2022

Btw, sorry for the slow replies this week, I've been moving into a new house.

@dvzrv
Copy link
Contributor Author

dvzrv commented Jun 7, 2022

Is there a reason to not support Python 3.6? I actually need it for one of the projects I work on due to the OS version and available packages. So I suspect other users also still need it.

Python 3.6 is not supported by upstream anymore, so there is no reason to support it in downstreams.
FWIW, prettytable now also only supports >= 3.7

@dvzrv
Copy link
Contributor Author

dvzrv commented Jun 7, 2022 •
edited

It appears that you have bumped the supported version of prettytable to < 4.0.0 in #1359 , so I guess this can be closed.

Dropping support for python 3.6 is nonetheless a good idea and should be done as soon as possible, as it prevents using newer language features, etc.

dvzrv added 2 commits June 7, 2022 19:22
@dvzrv
Increase supported python version to >=3.7.0
a71dde5 
setup.cfg:
Increase supported python version to >=3.7.0, as 3.6.0 is EOL.
@dvzrv
Remove python 3.6.0 from github actions
01eaa4e 
.github/workflows/basic_test.yaml:
Do not build against python 3.6.0 as it is EOL.
@dvzrv dvzrv force-pushed the increase_supported_python branch from ad77814 to 01eaa4e Compare June 7, 2022 17:26
@dvzrv
Copy link
Contributor Author

dvzrv commented Jun 7, 2022

I've rebased the commits on top of current default branch

@dvzrv
Copy link
Contributor Author

dvzrv commented Aug 27, 2022

Ping?

@flit flit mentioned this pull request Nov 23, 2022
Merged
@flit
Copy link
Member

flit commented Nov 23, 2022

Fyi, I've created a new PR #1477 based on this one, with a few minor changes like removing the dataclasses dependency.

@flit flit closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvzrv @flit