probe: block signals around USB transfers #1392
Open
+131
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch blocks all signals from being sent to the current thread before performing any USB transfer through pyusb.
For the separate receive threads created by some CMSIS-DAP USB backends, signals are permanently blocked.
The main reason to do this is that a SIGINT can cause a
KeyboardInterrupt
exception to be raised in the middle of pyusb and/or pyocd USB protocol related code. On occasion, this will cause the protocol to become out of sequence, resulting in all future transfers failing wildly.