debug: sequences: assignment expressions #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support C-style assignment expressions, such that variables can be assigned to in the middle of other expressions. Just as in C, the value of an assignment expression is the value assigned to the variable. While this syntax isn't documented in the Open-CMSIS-Pack specification, it is used in the Keil.LPC800_DFP pack and therefore is implicitly supported by debug sequences. The patch replaces the assign_stmt AST node with assign_expr, with the lowest precedence (same precedence as in C).
|
@imi415 Could you test this PR if you have time, please? Thanks! 🙏🏽 |
|
@imi415 Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support C-style assignment expressions, such that variables can be assigned to in the middle of other expressions. Just as in C, the value of an assignment expression is the value assigned to the variable. While this syntax isn't documented in the Open-CMSIS-Pack specification, it is used in the Keil.LPC800_DFP pack and therefore is implicitly supported by debug sequences.
The patch replaces the assign_stmt AST node with assign_expr, with the lowest precedence (same precedence as in C).
Fixes #1563