Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: cmsis-dap: usb backends: windows performance fix and more #1595

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

flit
Copy link
Member

@flit flit commented Jul 23, 2023

  • Fix performance regression for CMSIS-DAPv2 on certain machines running Microsoft Windows by using a real multithreaded queue with blocking support for passing data from receive thread.
  • Re-raise exceptions that occur in the receive thread from .read().
  • A few other small improvements.

- Fix performance regression for CMSIS-DAPv2 on certain machines
running Microsoft Windows by using a real multithreaded queue with
blocking support for passing data from receive thread.
- Re-raise exceptions that occur in the receive thread from .read().
- A few other small improvements.
@flit
Copy link
Member Author

flit commented Jul 24, 2023

cc @Guozhanxin If you have a chance to test this patch, that would be very helpful. Thanks!

@flit flit merged commit 37c8efb into pyocd:main Jul 30, 2023
21 checks passed
@flit flit deleted the bugfix/cmsis_dap_v2_windows_performance branch July 31, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression with CMSIS-DAP v2 between release 0.32.3 and 0.33.0
1 participant