Fix missing file in tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
force-pushed
the
missing_test_file
branch
from
8b7638d
to
9057dee
Compare
|
Looks like we are hitting pandas-dev/pandas#53234 in some test cases. I swapped the byte order for the test file for now. It seems like the least disruptive change to implement but I don't want to merge it yet b/c I want to move all binary files to pooch to avoid bloating the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the file as an asset in the past release to keep it here in this repo without contaminating the repo with the binary file.I moved all the test data files to an asset in the data release in https://github.com/pyoceans/pocean-core/releases/tag/2024.04. The release per se contains only a README with the files list and checksum. The release asset contains a zipped file with all the test data that is downloaded and unzip before the tests run. One can do this locally with
python pocean/tests/download_test_data.py.